Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display Beta, Obsolete, and Internal status and descriptions #217

Merged
merged 11 commits into from
Nov 20, 2023
Merged

feat: display Beta, Obsolete, and Internal status and descriptions #217

merged 11 commits into from
Nov 20, 2023

Conversation

burkedavison
Copy link
Contributor

@burkedavison burkedavison commented Oct 17, 2023 •
edited
Loading

See cl/582785739 for staging links.

@burkedavison burkedavison changed the title Display Beta, Obsolete, and Internal status and descriptions feat: display Beta, Obsolete, and Internal status and descriptions Nov 15, 2023
@burkedavison burkedavison marked this pull request as ready for review November 16, 2023 20:39
@burkedavison burkedavison requested a review from a team as a code owner November 16, 2023 20:39
alicejli
alicejli reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@alicejli alicejli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great feature to have! Several clarifying questions inline.

third_party/docfx-doclet-143274/src/main/java/com/microsoft/lookup/BaseLookup.java Show resolved Hide resolved
third_party/docfx-doclet-143274/src/main/java/com/microsoft/lookup/BaseLookup.java Show resolved Hide resolved
third_party/docfx-doclet-143274/src/main/java/com/microsoft/lookup/BaseLookup.java Show resolved Hide resolved
third_party/docfx-doclet-143274/src/main/java/com/microsoft/lookup/ClassLookup.java Show resolved Hide resolved
@lqiu96
Copy link
Contributor

lqiu96 commented Nov 17, 2023

A side note: I wonder if it may make sense (in a different PR) to prevent classes/ methods with @InternalApi from even showing up in documentation. It might help to discourage people from using it. On the other hand, they can still find the public/ protected classes and may be wondering why documentation doesn't exist.

@burkedavison burkedavison merged commit 489aca9 into main Nov 20, 2023
7 checks passed
@burkedavison burkedavison deleted the beta-obsolete-internal branch November 20, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

@alicejli alicejli alicejli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burkedavison @lqiu96 @alicejli