Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a Spec #8055

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix a Spec #8055

wants to merge 2 commits into from

Conversation

kyleVsteger
Copy link

While working with this API, I noticed that this spec (and likely others) are incorrect. It returns a list of GoogleApi.Firestore.V1.Model.RunQueryResponse structs.

The raw response from GoogleApi.Firestore.V1.Api.Projects.firestore_projects_databases_documents_run_query is

{:ok,
 [
   %GoogleApi.Firestore.V1.Model.RunQueryResponse{
     document: %GoogleApi.Firestore.V1.Model.Document{
       createTime: ~U[2020-09-02 23:42:57.807167Z],
       fields: %{
         "UID" => %GoogleApi.Firestore.V1.Model.Value{
           arrayValue: nil,
           booleanValue: nil,
           bytesValue: nil,
           doubleValue: nil,
           geoPointValue: nil,
           integerValue: nil,
           mapValue: nil,
           nullValue: nil,
           referenceValue: nil,
           stringValue: "REDACTED",
           timestampValue: nil
         },
         "savedSearches" => %GoogleApi.Firestore.V1.Model.Value{
           arrayValue: %GoogleApi.Firestore.V1.Model.ArrayValue{values: nil},
           booleanValue: nil,
           bytesValue: nil,
           doubleValue: nil,
           geoPointValue: nil,
           integerValue: nil,
           mapValue: nil,
           nullValue: nil,
           referenceValue: nil,
           stringValue: nil,
           timestampValue: nil
         }
       },
       name: "REDACTED",
       updateTime: ~U[2020-10-19 20:17:43.477743Z]
     },
     readTime: ~U[2021-06-02 19:04:32.970584Z],
     skippedResults: nil,
     transaction: nil
   }
 ]}

@kyleVsteger kyleVsteger requested a review from a team as a code owner June 2, 2021 19:12
@google-cla
Copy link

google-cla bot commented Jun 2, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant