Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit to 20 batches of 100 records per count task. #751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Limit to 20 batches of 100 records per count task. #751

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,8 @@ def get(self):
counter = model.Counter.get_unfinished_or_create(
self.repo, self.SCAN_NAME)
entities_remaining = True
while entities_remaining:
batches_done = 0
while entities_remaining and batches_done < 20:
# Batch the db updates.
for _ in xrange(100):
entities_remaining = run_count(
Expand All @@ -185,6 +186,9 @@ def get(self):
break
# And put the updates at once.
counter.put()
batches_done += 1
self.add_task_for_repo(self.repo, self.SCAN_NAME, self.ACTION)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite understand this change -- I get the limit on the batching, but why do you now call add_task_for_repo where you didn't before?

return
except runtime.DeadlineExceededError:
# Continue counting in another task.
self.add_task_for_repo(self.repo, self.SCAN_NAME, self.ACTION)
Expand Down