Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

Handlers in MiTM server for detection of PII in HTTP and HTTPS traffic #100

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mkenne11
Copy link

Handlers httppii and httpspii added to detect PII in HTTP and HTTPS traffic.

@mkenne11
Copy link
Author

This is 1 of 3 PRs to add Android app PII detection functionality to nogotofail.

The code added to the MiTM server, Android client and Android test harness components were separated across 3 PRs to hopefully simplify code review.
Note. All 3 PRs need to be merged to ensure functionality is in sync.

@mkenne11 mkenne11 changed the title Added handlers to detect PII in HTTP and HTTPS traffic Added handlers to MiTM server for detection of PII in HTTP and HTTPS traffic Jan 10, 2016
@mkenne11
Copy link
Author

I generated timing metrics for the key PII handler methods. The timings were performed on a GCE server type "g1-small". During testing 10 Android apps were "manually" used over a 5 minute period and the server attempted to detect 10 PII data items (plus base-64 and URL encoded variants).

The times shown are the maximum time taken for each method, however the average time for each method was an order of magnitude faster.

"httppii" handler (class HttpPiiDetection):

  • method "on_http_request": 0.0005s
  • method "on_http_response": 0.0002s

"httpspii" handler (class HttpsPiiDetection):

  • method "on_https_request": 0.005s
  • method "on_https_response": 0.002s

I had trouble determing the best way to structure the HTTP and HTTPS PII handlers. "httppii" is a data handler and "httpspii" is a connection handler - there is a bit of code duplication between the two handler methods. I am keen to hear any suggestions you have on how to structure these :)

@mkenne11 mkenne11 changed the title Added handlers to MiTM server for detection of PII in HTTP and HTTPS traffic Handlers in MiTM server for detection of PII in HTTP and HTTPS traffic Jan 10, 2016
New Handlers httppii and httpspii added to detect PII in HTTP and HTTPS traffic.

Also added documentation describing how to use the PII handlers.
@mkenne11
Copy link
Author

Removed some unnecessary code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants