Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation/test for GlobalString destruction. #337

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Add implementation/test for GlobalString destruction. #337

merged 1 commit into from
Sep 13, 2024

Commits on Sep 13, 2024

  1. Add implementation/test for GlobalString destruction. 

    This was actually causing premature releases of `GlobalString` when directly constructed with arguments because it wasn't promoting its `LocalObject` after construction.

Also, add tests for graceful destruction of GlobalObject which isn't returned.

PiperOrigin-RevId: 674475063
    @jwhpryor @copybara-github
    jwhpryor authored and copybara-github committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    954558c View commit details
    Browse the repository at this point in the history