Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings #981

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/draco/core/bounding_box.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ BoundingBox::BoundingBox()
BoundingBox::BoundingBox(const Vector3f &min_point, const Vector3f &max_point)
: min_point_(min_point), max_point_(max_point) {}

const bool BoundingBox::IsValid() const {
bool BoundingBox::IsValid() const {
return GetMinPoint()[0] != std::numeric_limits<float>::max() &&
GetMinPoint()[1] != std::numeric_limits<float>::max() &&
GetMinPoint()[2] != std::numeric_limits<float>::max() &&
Expand Down
2 changes: 1 addition & 1 deletion src/draco/core/bounding_box.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class BoundingBox {
// Checks if the bounding box object was created with the default constructor
// then never updated. Internally, checks if the bounding box minimum and
// maximum points hold the largest positive and smallest negative values.
const bool IsValid() const;
bool IsValid() const;

// Conditionally updates the bounding box with a given |new_point|.
void Update(const Vector3f &new_point) {
Expand Down
1 change: 1 addition & 0 deletions src/draco/core/draco_index_type.h
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ class IndexType {
typedef ValueTypeT ValueType;

constexpr IndexType() : value_(ValueTypeT()) {}
constexpr IndexType(const IndexType &i) : value_(i.value_) {}
constexpr explicit IndexType(ValueTypeT value) : value_(value) {}

constexpr ValueTypeT value() const { return value_; }
Expand Down