Use CMAKE_MSVC_RUNTIME_LIBRARY to select BoringSSL C runtime. #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes CI on Windows. Unsure exactly what triggered it upstream but without this, cmake starting adding /MD to the cflags and overriding ours, causing link errors. Switching Conscrypt to /MT causes runtime crashes. This fix seems better than setting the flags directly anyway. Maybe worth upstreaming as the default unless there are use cases for CMAKE_MSVC_RUNTIME_LIBRARY=MultiThreadedDLL
prbprbprb
changed the title
davidben
approved these changes
Sep 16, 2024
Hmm, no idea. TBH I'm unclear on what the expectations are for library packages in CMake. I presume you need this to be the same across everything you link? In that case, are libraries supposed to be opinionated or just inherit it from the user? |
Fair point, probably just inherit from the rest of the project. I didn't dig into why Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CMAKE_MSVC_RUNTIME_LIBRARY to select BoringSSL C runtime.
Fixes CI on Windows.
Unsure exactly what triggered it upstream but without this, cmake
starting adding /MD to the cflags and overriding ours, causing
link errors. Switching Conscrypt to /MT causes runtime crashes.
This fix seems better than setting the flags directly anyway.
Maybe worth upstreaming as the default unless there are use cases
for CMAKE_MSVC_RUNTIME_LIBRARY=MultiThreadedDLL