Make tests agnostic about TLS v1.x. #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test only change. Ensures tests neither use nor assume anything about whether TLSv.1 are enabled or supported. As such it is suitable for backporting to historic Android test suites where vendors may have disabled TLS v1.x by editing the default arrays. However by being agnostic it does not enforce that TLS v1.x are available if expected. A further change will provide an API for that, but which is not suitable for backporting as it will require non-test changes. A lot of the tidy-up is around RenegotiationTest and its TestUtils methods, which are only tested on OpenJDK builds.
miguelaranda0
approved these changes
Jun 26, 2023
Yqwed
reviewed
Jun 26, 2023
testing/src/main/java/org/conscrypt/java/security/StandardNames.java
Outdated
Show resolved
Hide resolved
Yqwed
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test only change. Ensures tests neither use nor assume anything about whether TLSv.1 are enabled or supported. As such it is suitable for backporting to historic Android test suites where vendors may have disabled TLS v1.x by editing the default arrays.
However by being agnostic it does not enforce that TLS v1.x are available if expected. A further change will provide an API for that, but which is not suitable for backporting as it will require non-test changes.
A lot of the tidy-up is around RenegotiationTest and its TestUtils methods, which are only tested on OpenJDK builds.