Adding HPKE support for crypto operations per RFC-9180 #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supported cryptographic schemes: KEM (key encapsulation mechanism) - 0x0020: DHKEM(X25519, HKDF-SHA256) KDF (key derivation function) - 0x0001: HKDF-SHA256 AEAD (Authenticated Encryption with Associated Data) - 0x0001: AES-128-GCM - 0x0002: AES-256-GCM - 0x0003: ChaCha20Poly1305
|
LGTM and tests pass under Gradle+OpenJDK... I haven't really reviewed the JNI code, hoping @davidben can do the honours. David: The public APIs here are for OpenJDK only, on Android there will be a delegating API from a different namespace... Jorge can point you at the CL for that if needed. |
davidben
reviewed
Jun 26, 2023
jorgesaldivar
pushed a commit
to jorgesaldivar/conscrypt
that referenced
this pull request
Jul 19, 2023
jorgesaldivar
pushed a commit
to jorgesaldivar/conscrypt
that referenced
this pull request
Jul 19, 2023
davidben
reviewed
Aug 7, 2023
davidben
reviewed
Aug 14, 2023
davidben
approved these changes
Aug 14, 2023
prbprbprb
approved these changes
Aug 15, 2023
Thanks for all your help, David! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported cryptographic schemes:
KEM (key encapsulation mechanism)
KDF (key derivation function)
AEAD (Authenticated Encryption with Associated Data)