Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify toQueryString to prevent SQLite expression tree from exceeding depth of 1000 #2565

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2021-2023 Google LLC
* Copyright 2021-2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -86,15 +86,18 @@ internal sealed class FilterCriteria(
* intended.
*/
private fun List<ConditionParam<*>>.toQueryString(operation: Operation) =
this.joinToString(
separator = " ${operation.logicalOperator} ",
prefix = if (size > 1) "(" else "",
postfix = if (size > 1) ")" else "",
) {
if (it.params.size > 1) {
"(${it.condition})"
} else {
it.condition
this.chunked(50) { conditionParams ->
Copy link
Collaborator

@pld pld Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MJ1998 do you have thoughts on what the chunk size should be?

conditionParams.joinToString(
separator = " ${operation.logicalOperator} ",
prefix = if (size > 1) "(" else "",
postfix = if (size > 1) ")" else "",
) {
if (it.params.size > 1) {
"(${it.condition})"
} else {
it.condition
}
Comment on lines +92 to +96
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make this a function in the class ConditionParam actually? will look this code look better.

}
}
}
.joinToString(separator = " ${operation.logicalOperator} ")
}
Loading