Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with proxy.golang.org #1974

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Conversation

sanyatuning
Copy link
Contributor

@sanyatuning sanyatuning commented Jul 9, 2024

What is the problem I am trying to address?

Empty response body when major version not found.
The official proxy responds with a non-empty body.
(And some library depends on this)

$ curl 'https://proxy.golang.org/github.com/!ak-!army/xlog/v2/@v/list'
not found: module github.com/Ak-Army/xlog/v2: no matching versions for query "latest"

How is the fix applied?

I created a simplified solution for my case.
Can you update it to fit your conventions?

What GitHub issue(s) does this PR fix or close?

Fixes icholy/gomajor#34

@sanyatuning sanyatuning requested a review from a team as a code owner July 9, 2024 06:37
@matt0x6F
Copy link
Contributor

@sanyatuning Thanks for your contribution to Athens! Do you mind writing a test that ensures this behaivor?

@matt0x6F matt0x6F added the enhancement New feature or request label Jul 15, 2024
@matt0x6F matt0x6F enabled auto-merge (squash) September 9, 2024 03:11
@matt0x6F matt0x6F merged commit 70ee634 into gomods:main Sep 9, 2024
11 checks passed
DrPsychick referenced this pull request in gomods/athens-charts Sep 14, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [gomods/athens](https://redirect.github.com/gomods/athens) | minor |
`v0.14.1` -> `v0.15.1` |

---

### Release Notes

<details>
<summary>gomods/athens (gomods/athens)</summary>

###
[`v0.15.1`](https://redirect.github.com/gomods/athens/releases/tag/v0.15.1)

[Compare
Source](https://redirect.github.com/gomods/athens/compare/v0.15.0...v0.15.1)

#### What's Changed

- update-github-action(deps): bump goreleaser/goreleaser-action from 5
to 6 by [@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/gomods/athens/pull/1969](https://redirect.github.com/gomods/athens/pull/1969)
- update-github-action(deps): bump docker/build-push-action from 5 to 6
by [@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/gomods/athens/pull/1971](https://redirect.github.com/gomods/athens/pull/1971)
- Add aad auth option when using azure storage account by
[@&#8203;SilverdewBaker](https://redirect.github.com/SilverdewBaker) in
[https://github.com/gomods/athens/pull/1973](https://redirect.github.com/gomods/athens/pull/1973)
- Fix helm install command in docs by
[@&#8203;sb464f](https://redirect.github.com/sb464f) in
[https://github.com/gomods/athens/pull/1981](https://redirect.github.com/gomods/athens/pull/1981)
- Switch from ADAL to AzIdentity, Add Azure Storage Token Refresh, and
Update Golang Version by
[@&#8203;SilverdewBaker](https://redirect.github.com/SilverdewBaker) in
[https://github.com/gomods/athens/pull/1977](https://redirect.github.com/gomods/athens/pull/1977)
- Compatibility with proxy.golang.org for list not found responses by
[@&#8203;sanyatuning](https://redirect.github.com/sanyatuning) in
[https://github.com/gomods/athens/pull/1974](https://redirect.github.com/gomods/athens/pull/1974)
- Fix: Change goreleaser flag from --rm-dist to --clean by
[@&#8203;matt0x6F](https://redirect.github.com/matt0x6F) in
[https://github.com/gomods/athens/pull/1984](https://redirect.github.com/gomods/athens/pull/1984)

#### New Contributors

- [@&#8203;SilverdewBaker](https://redirect.github.com/SilverdewBaker)
made their first contribution in
[https://github.com/gomods/athens/pull/1973](https://redirect.github.com/gomods/athens/pull/1973)
- [@&#8203;sb464f](https://redirect.github.com/sb464f) made their first
contribution in
[https://github.com/gomods/athens/pull/1981](https://redirect.github.com/gomods/athens/pull/1981)
- [@&#8203;sanyatuning](https://redirect.github.com/sanyatuning) made
their first contribution in
[https://github.com/gomods/athens/pull/1974](https://redirect.github.com/gomods/athens/pull/1974)

**Full Changelog**:
gomods/athens@v0.14.1...v0.15.1

###
[`v0.15.0`](https://redirect.github.com/gomods/athens/releases/tag/v0.15.0)

[Compare
Source](https://redirect.github.com/gomods/athens/compare/v0.14.1...v0.15.0)

#### What's Changed

- update-github-action(deps): bump goreleaser/goreleaser-action from 5
to 6 by [@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/gomods/athens/pull/1969](https://redirect.github.com/gomods/athens/pull/1969)
- update-github-action(deps): bump docker/build-push-action from 5 to 6
by [@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/gomods/athens/pull/1971](https://redirect.github.com/gomods/athens/pull/1971)
- Add aad auth option when using azure storage account by
[@&#8203;SilverdewBaker](https://redirect.github.com/SilverdewBaker) in
[https://github.com/gomods/athens/pull/1973](https://redirect.github.com/gomods/athens/pull/1973)
- Fix helm install command in docs by
[@&#8203;sb464f](https://redirect.github.com/sb464f) in
[https://github.com/gomods/athens/pull/1981](https://redirect.github.com/gomods/athens/pull/1981)
- Switch from ADAL to AzIdentity, Add Azure Storage Token Refresh, and
Update Golang Version by
[@&#8203;SilverdewBaker](https://redirect.github.com/SilverdewBaker) in
[https://github.com/gomods/athens/pull/1977](https://redirect.github.com/gomods/athens/pull/1977)
- Compatibility with proxy.golang.org for list not found responses by
[@&#8203;sanyatuning](https://redirect.github.com/sanyatuning) in
[https://github.com/gomods/athens/pull/1974](https://redirect.github.com/gomods/athens/pull/1974)

#### New Contributors

- [@&#8203;SilverdewBaker](https://redirect.github.com/SilverdewBaker)
made their first contribution in
[https://github.com/gomods/athens/pull/1973](https://redirect.github.com/gomods/athens/pull/1973)
- [@&#8203;sb464f](https://redirect.github.com/sb464f) made their first
contribution in
[https://github.com/gomods/athens/pull/1981](https://redirect.github.com/gomods/athens/pull/1981)
- [@&#8203;sanyatuning](https://redirect.github.com/sanyatuning) made
their first contribution in
[https://github.com/gomods/athens/pull/1974](https://redirect.github.com/gomods/athens/pull/1974)

**Full Changelog**:
gomods/athens@v0.14.1...v0.15.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/gomods/athens-charts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: DrPsychick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants