Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-go-pkg(deps): bump github.com/gorilla/mux from 1.6.2 to 1.8.0 #1763

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 28, 2022

Bumps github.com/gorilla/mux from 1.6.2 to 1.8.0.

Release notes

Sourced from github.com/gorilla/mux's releases.

v1.8.0 ☀️

v1.8.0 addresses a minor regression with the variable extraction when using a wildcard host match. Specifying .Host(“foo.example.com:{port:.*}) will now correctly capture the port into mux.Vars.

CHANGELOG

v1.7.4 addresses a number of performance improvements (#544), bugs (#509, #535), and documentation improvements.

CHANGELOG

v1.7.3

This is a patch release that mostly incorporates test & build system updates, as well as fixing a rare cause of panics.

CHANGELOG

v1.7.2

⚠️ This release relaxes the host:port matching when using *Route.Host() as introduced in v1.7.0. If a port is not provided, the route will match on any port, matching behaviour for all versions of mux prior to v1.7.0.

See #447 for a fuller discussion.

CHANGELOG

  • Route.Host -matching will ignore any provided port from getHost(), if… (#447) @​cognusion

... (truncated)

Commits
  • 98cb6bf fix: regression in vars extract for wildcard host (#579)
  • 948bec3 docs: Remove stale text from comment. (#568)
  • 75dcda0 perf: reduce allocations in (*routeRegexp).getURLQuery (#544)
  • 49c0148 lint: Remove golint warning (#526)
  • 4de8a5a fix headers regexp test (#536)
  • 2854a05 Merge pull request #535 from fharding1/cors-subrouter-bug
  • 946b623 Fix the CORSMethodMiddleware bug with subrouters
  • f395758 Remove/cleanup request context helpers (#525)
  • ff4e71f Guess the scheme if r.URL.Scheme is unset (#474)
  • 884b5ff Added capacity to slice creation, when capacity is known (#516)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot requested a review from a team as a code owner February 28, 2022 01:15
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Feb 28, 2022
Copy link
Member

@arschles arschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the implications of this, but if someone's willing to look at whether anything material changed between these versions, I'm all for merging

@dependabot dependabot bot force-pushed the dependabot/go_modules/main/github.com/gorilla/mux-1.8.0 branch 2 times, most recently from 8993845 to 9f98702 Compare March 21, 2022 17:48
@dependabot dependabot bot force-pushed the dependabot/go_modules/main/github.com/gorilla/mux-1.8.0 branch from 9f98702 to b19b89d Compare April 1, 2022 05:36
Bumps [github.com/gorilla/mux](https://github.com/gorilla/mux) from 1.6.2 to 1.8.0.
- [Release notes](https://github.com/gorilla/mux/releases)
- [Commits](gorilla/mux@v1.6.2...v1.8.0)

---
updated-dependencies:
- dependency-name: github.com/gorilla/mux
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/main/github.com/gorilla/mux-1.8.0 branch from b19b89d to 13da34e Compare June 4, 2022 04:31
@nrwiersma
Copy link
Contributor

The changes dont seem ground breaking, mainly a Go version bump and some bug fixes. The real issue at this point is that gorilla/mux has been archived, so likely a new mux is needed none the less.

@DrPsychick DrPsychick added this to the 0.13.0 milestone Jun 23, 2023
@DrPsychick DrPsychick modified the milestones: 0.13.0, 0.13.x thereafter Jun 23, 2023
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 6, 2023

A newer version of github.com/gorilla/mux exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@matt0x6F
Copy link
Contributor

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 19, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@matt0x6F
Copy link
Contributor

@dependabot recreate

Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 19, 2024

Superseded by #1917.

@dependabot dependabot bot closed this Feb 19, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/main/github.com/gorilla/mux-1.8.0 branch February 19, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants