-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
websocket: Clarify the status of the package as retired #175
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@mortie There's a typo in your PR ( |
@binwiederhier I fixed the typo. I also replaced the link to nhooyr.io/websocket with a link to gorilla/websocket, since that's apparently no longer inactive; see gorilla/websocket@931041c and the announcement at https://github.com/gorilla. |
There doesn't seem to be much interest in this. Should I just close the PR? Is the |
这个包满足我的,因为很小,而且是官方维护。唯一不足的地方大多数人没法用它,因为不会Read。
|
Is this repo dead? |
The websocket package is retired, as explained in golang/go#2134 (comment), and its neglect has been a topic of discussion since at least 2016 (see golang/go#18152). However, to this day, the documentation on pkg.go.dev doesn't make the status of the package clear, as I pointed out in golang/go#60467.
This PR changes the wording to explicitly state that the package is in fact retired, as opposed to simply "lacking some features".