Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: send client conn flow control bytes back immediately #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jronak
Copy link
Contributor

@jronak jronak commented Aug 7, 2022

HTTP/2 server must send client connection flow control bytes
back immediately on receiving the data frame. Connection flow control
updates must not depend on whether data has been read by the
application handler or not. This prevents fast streams from starving
due to slow streams.

Fixes: golang/go#54330

HTTP/2 server must return client connection flow control bytes
back immediately on receiving data frame. Connection flow control
updates must not depend on whether data has been read by application
handler or not. This prevents fast streams from starving due to
slow streams.
@gopherbot
Copy link
Contributor

This PR (HEAD: 892fc35) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/421975 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 1: Hold+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/421975.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/net/http2: slow streams can potentially block other faster streams
2 participants