add rust programs to path #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatanabe
approved these changes
Jun 25, 2024
| @@ -85,6 +85,9 @@ RUN mkdir -p ${PSINODE_PATH} \ | |||
| && git clone https://github.com/gofractally/psibase.git . \ | |||
| && git submodule update --init --recursive | |||
|
|
|||
| # Add locally built rust programs to path | |||
| ENV PATH=${PSINODE_PATH}/build/rust/release:$PATH | |||
There was a problem hiding this comment.
Is this the right way, or would it be better to install cargo-psibase?
There was a problem hiding this comment.
Hmm, I've been thinking that it's better to use the locally built one. Just like we don't install psinode and psibase from the last psidk release either
There was a problem hiding this comment.
I meant, should cargo-psibase be installed to psidk/bin (like psibase) instead of being used from the build directory.
There was a problem hiding this comment.
Oh, I see, that's probably a good idea. Although that would mean that cargo-psibase would be distributed with psidk, right? I'd imagine typically the correct way to install cargo-psibase is using cargo install directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily so we can more easily use locally built
cargo-psibasein psibase contributor