write traces to console by default #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Mart
force-pushed
the
write-traces-to-console
branch
from
4c4dddc
to
a611aa1
Compare
James-Mart
force-pushed
the
write-traces-to-console
branch
from
a611aa1
to
c779054
Compare
James-Mart
commented
Feb 27, 2024
| @@ -91,7 +91,7 @@ jobs: | |||
| build-contributor: | |||
| name: "Build contributor" | |||
| needs: [determine-actions, build-tool-config, build-2204] | |||
| if: ${{ needs.determine-actions.outputs.run_contrib == '1' }} | |||
| if: ${{ !cancelled() && needs.determine-actions.outputs.run_contrib == '1' }} | |||
There was a problem hiding this comment.
Strange behavior in github actions: If a needs job is skipped, then dependent jobs will be skipped, regardless whether the if condition passes.
Publicly known workaround appears to be to use always() in the if condition, but then the job can't be cancelled. From my testing it appears that !cancelled() is also a workaround but it has the benefit of still being cancellable.
swatanabe
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on gofractally/psibase#615