Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Thesis MS] Fixes for Self-Validation Issues #1545

Merged
merged 6 commits into from
Jul 24, 2024
Merged

[Thesis MS] Fixes for Self-Validation Issues #1545

merged 6 commits into from
Jul 24, 2024

Conversation

michael-schwarz
Copy link
Member

@michael-schwarz michael-schwarz commented Jul 16, 2024 •
edited
Loading

Should address #1542 and #1547.

Contains:

  • Fix for issue where read_global read in from a global variable which does not exist in single-threaded mode
  • Fix for writing out invariants about stale local copy of escaped variables.

Related but not part of the diff:

  • 3a30b0c (check whether cast to long long is injective before emitting invariants)

@michael-schwarz michael-schwarz marked this pull request as ready for review July 24, 2024 09:24
@michael-schwarz michael-schwarz merged commit 0639c74 into michael-schwarz-dissertation Jul 24, 2024
17 of 19 checks passed
@michael-schwarz michael-schwarz deleted the witness_val_fail branch July 24, 2024 09:24
@michael-schwarz
Copy link
Member Author

For closing #1542 and #1547, we should backport this and 3a30b0c to master.

@michael-schwarz michael-schwarz mentioned this pull request Jul 24, 2024
Draft
@sim642 sim642 self-requested a review July 24, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sim642 sim642 Awaiting requested review from sim642

Assignees
No one assigned
Labels
bug unsound
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michael-schwarz