Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(queue)!: add pub key item opening #498

Merged
merged 456 commits into from
Aug 31, 2023
Merged

feat(queue)!: add pub key item opening #498

merged 456 commits into from
Aug 31, 2023

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Aug 8, 2023

depends on go-vela/server#843

KellyMerrick and others added 30 commits August 6, 2021 15:55
* feat(internal): add logic from pkg-executor

* chore: clean go dependencies

* chore: address linter feedback
* feat(executor): add logic from pkg-executor

* chore: clean go dependencies
* revert: stream container logs

* feat: add flag to enable streaming logs

* feat(executor): add logic to stream logs if enabled

* enhance: make log publishing method configurable

* enhance: use configurable log publishing method

* chore: configure time log publish method for local

* chore: address linter feedback

* chore: fix tests for code changes

* chore: address linter feedback v2
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #498 (6133b6f) into main (a8bfa16) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #498   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files          69       69           
  Lines        5376     5376           
=======================================
  Hits         4485     4485           
  Misses        746      746           
  Partials      145      145           

@plyr4 plyr4 marked this pull request as draft August 16, 2023 14:29
@plyr4 plyr4 marked this pull request as ready for review August 17, 2023 16:42
@plyr4 plyr4 changed the title feat!: queue signing, open items with pub key feat!(queue): add pub key item opening Aug 17, 2023
@plyr4
Copy link
Contributor Author

plyr4 commented Aug 17, 2023

sorry about the commit history, this branch must have diverted off another branch or something

@plyr4 plyr4 changed the title feat!(queue): add pub key item opening feat(queue)!: add pub key item opening Aug 23, 2023
timhuynh94
timhuynh94 previously approved these changes Aug 23, 2023
KellyMerrick
KellyMerrick previously approved these changes Aug 23, 2023
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 dismissed stale reviews from KellyMerrick and timhuynh94 via e6651c1 August 25, 2023 16:18
@plyr4 plyr4 merged commit f7fb2a0 into main Aug 31, 2023
11 checks passed
@plyr4 plyr4 deleted the feat/queue-signing branch August 31, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.