-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(queue)!: add pub key item opening #498
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
* feat(internal): add logic from pkg-executor * chore: clean go dependencies * chore: address linter feedback
* feat(executor): add logic from pkg-executor * chore: clean go dependencies
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Neal Coleman <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Kelly Merrick <[email protected]>
* revert: stream container logs * feat: add flag to enable streaming logs * feat(executor): add logic to stream logs if enabled * enhance: make log publishing method configurable * enhance: use configurable log publishing method * chore: configure time log publish method for local * chore: address linter feedback * chore: fix tests for code changes * chore: address linter feedback v2
plyr4
force-pushed
the
feat/queue-signing
branch
from
August 11, 2023 20:00
bfa7eeb
to
2a744ec
Compare
Codecov Report
@@ Coverage Diff @@
## main #498 +/- ##
=======================================
Coverage 83.42% 83.42%
=======================================
Files 69 69
Lines 5376 5376
=======================================
Hits 4485 4485
Misses 746 746
Partials 145 145 |
plyr4
changed the title
feat!: queue signing, open items with pub key
feat!(queue): add pub key item opening
Aug 17, 2023
sorry about the commit history, this branch must have diverted off another branch or something |
plyr4
changed the title
feat!(queue): add pub key item opening
feat(queue)!: add pub key item opening
Aug 23, 2023
timhuynh94
previously approved these changes
Aug 23, 2023
KellyMerrick
previously approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
timhuynh94
approved these changes
Aug 29, 2023
ecrupper
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on go-vela/server#843