feat(queue): use GetInfo for setup #1467
Triggered via pull request
September 25, 2023 16:10
timhuynh94
Status
Success
Total duration
3m 13s
Artifacts
–
reviewdog.yml
on: pull_request
diff-review
1m 14s
full-review
3m 2s
Annotations
10 errors
|
full-review:
runtime/kubernetes/mock.go#L145
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
|
full-review:
runtime/kubernetes/pod_tracker.go#L229
Error return value of `(k8s.io/client-go/tools/cache.SharedInformer).AddEventHandler` is not checked (errcheck)
|
|
full-review:
cmd/vela-worker/exec.go#L300
Comment should end in a period (godot)
|
|
full-review:
runtime/kubernetes/apis/doc.go#L1
Expected:2023, Actual: 2022 Target Brands, Inc. All rights reserved. (goheader)
|
|
full-review:
internal/doc.go#L1
Expected:2023, Actual: 2022 Target Brands, Inc. All rights reserved. (goheader)
|
|
full-review:
internal/internal.go#L1
Expected:2023, Actual: 2022 Target Brands, Inc. All rights reserved. (goheader)
|
|
full-review:
mock/docker/service.go#L25
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
mock/docker/image.go#L33
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
mock/docker/swarm.go#L24
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
runtime/kubernetes/container.go#L75
unused-parameter: parameter 'b' seems to be unused, consider removing or renaming it as _ (revive)
|