Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboards): support dashboards service in SDK #311

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented May 6, 2024

This will primarily be used for CLI integration with Dashboards API

@ecrupper ecrupper requested a review from a team as a code owner May 6, 2024 15:48
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (64f8eb0) to head (75ca1d9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
+ Coverage   89.19%   89.47%   +0.27%     
==========================================
  Files          20       21       +1     
  Lines         796      817      +21     
==========================================
+ Hits          710      731      +21     
  Misses         52       52              
  Partials       34       34              
Files Coverage Δ
vela/client.go 90.95% <100.00%> (+0.04%) ⬆️
vela/dashboard.go 100.00% <100.00%> (ø)

vela/dashboard.go Outdated Show resolved Hide resolved
@ecrupper ecrupper merged commit 54c8961 into main May 7, 2024
7 of 10 checks passed
@ecrupper ecrupper deleted the feat/dashboards branch May 7, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants