-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: thumbnail should show last thumbnail in server in any condition #858
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
==========================================
- Coverage 35.17% 34.08% -1.10%
==========================================
Files 61 60 -1
Lines 4065 4008 -57
==========================================
- Hits 1430 1366 -64
- Misses 2413 2420 +7
Partials 222 222 ☔ View full report in Codecov by Sentry. |
return { | ||
backgroundImage: `url("${this.imageURL}")`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use some properties from the bookmark instead of a random string? This could break the cache unintentially since each time the query string is going to be different. Can we use ?mtime=<bookmark modified time>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will modified time update if just thumbnail update in article? i am sure that i am not update that in #683 so if that will handle in other part of code automatically we can use modified time too.
i don't find when modified time update in code. do you know where is that or i can send request to update that while thumbnail update
if just thumbnail will update but modify time not update automatically than it will get in trouble in that situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always assumed Bookmark.ModifiedTime
was the datetime when the bookmark was last modified (attributes/archive/readable/ebook) modified, it seems that is not the case. Let me think and get back to you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up not updating you here.
My idea is:
- Refactor the migration system (feat: new migration system #876)
- Add a
created
column to the bookmarks with the time the bookmark was first created and prefill it with the currentmodified
for existing bookmarks. - Update
modified
every time the bookmark is updated (either the data, content, archive, etc).
Then, we can use the modified
as query parameter for the thumbnail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is better so i will wait until #876 finish than start working on that.
but an small point: i like the idea of keep first created time and modified time separately if exist instead of prefill (you can look at #848)
so created and modified be better to separated. having created time help me to track my activity in long term so i think having that can be helpful.
@fmartingr and @GreenBlast what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you mention the function that currently update modified time? i can't find that (to use when just thumbnail update).
I'm thinking that instead of the query parameter, what do you think if we send the
What do you think? |
@fmartingr thanks for idea. i prefer this way but after review some question stil exist for me:
do you want approach 2 or 3? |
Can you refactor Something along the lines:
And if we don't provide What do you think? |
@fmartingr i work on that to impeliment ETag there too.
but combine Etag (improve performance no need each time open that file 7fb2721) with previous approach (add modifiedAt to that url c91ce2c) can be somehow useless in this case because if we used modifiedAt than unnecessary request will not send by default do you have any idea? |
If the best course of action here is to provide a queryparameter with the modified time, let's go for that so we fix the bug. Any improvements can be handled later. |
@fmartingr i use queryparamet |
thumbnail not update in browser sometimes.
bun.lockb
update withmake style
so i just push that too.Closes #857
Depends on #896