-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): references between different sources are consistent when watch #2868
base: main
Are you sure you want to change the base?
fix(config): references between different sources are consistent when watch #2868
Conversation
@shenqidebaozi Hi, our project needs to use this function, can we speed up the schedule? |
@zhan3333 ok |
@zhan3333 please fix lint |
a1daa5d
to
2f37620
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2868 +/- ##
==========================================
+ Coverage 84.50% 84.63% +0.12%
==========================================
Files 88 88
Lines 3970 3982 +12
==========================================
+ Hits 3355 3370 +15
+ Misses 439 435 -4
- Partials 176 177 +1
|
@shenqidebaozi the lint fix has been completed |
@shenqidebaozi ping |
@magic Baoziping |
could you please provide more detailed background and modification instructions |
Of course @shenqidebaozi Problem: When a configuration is referenced across source config, updates to the referenced configuration cannot affect the referenced key. How it works: Because the reference configuration is already processed to a specific value in reader, merge to reader does not trigger an update of the reference configuration. For example: source1:
source2:
After reader:
When new reader
Clearly, updates to key2 do not affect the value of the reference configuration key, causing the problem. Solution: When watch changes, Re-read the sources, this will make the |
@shenqidebaozi ping |
@magic Baoziping |
Description (what this PR does / why we need it):
Fixed an issue where watch did not work when referencing configuration updates between multiple sources
Which issue(s) this PR fixes (resolves / be part of):
fixes #2801
Other special notes for the reviewers:
/