Use official SQL Server docker image for tests #7205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2024
|
My modification in go-gorm/sqlserver#142 passed the test, which can be for reference. |
omkar-foss
force-pushed
the
mssql-docker-image
branch
from
1a5889b
to
af233e4
Compare
|
This PR is now ready for review, kindly review and let me know if any further changes are required. Thank you! |
jinzhu
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
This replaces the community SQL Server docker image (https://hub.docker.com/r/mcmoe/mssqldocker) with the official one (https://hub.docker.com/r/microsoft/mssql-server).
User Case Description
This is an attempt to fix the failing SQL Server workflow in GitHub actions (example here).