-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: migrator run with nil schema (#5795) #6303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change, because we use if stmt.Schema == nil
in many places to judge
Okay, I'll modify it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test cases need to wait for drivers to be merged.
Can tests cover changes? For example, AlterColumn/AddColumn needs to provide datatype, so it does not support specifying by table name, and an error needs to be returned at this time.
modified~ |
The driver changes have been merged, I re-triggered the ci but the test still fails, is it related to this change? |
I will check it. |
When CREATE INDEX `idx_users_name_1` ON `index_structs`(`name`) This is a bug, right? Because idx_index_structs_name still exist. |
yes |
What did this pull request do?
fix
DropColumn
RenameColumn
HasColumn
with string table param.Close #5795
User Case Description
It should work instead of panic