Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed race condition when deleting documents by repoId in ElasticSearch #32185

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Fixed race condition when deleting documents by repoId in ElasticSearch #32185

merged 2 commits into from
Oct 3, 2024

Conversation

bsofiato
Copy link
Contributor

@bsofiato bsofiato commented Oct 3, 2024

Resolves #32184

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 3, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 3, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 3, 2024
@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label Oct 3, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 3, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 3, 2024
@denyskon denyskon added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Oct 3, 2024
@denyskon denyskon added this to the 1.23.0 milestone Oct 3, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) October 3, 2024 15:34
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 3, 2024
@techknowlogick techknowlogick merged commit d266d19 into go-gitea:main Oct 3, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 3, 2024
@bsofiato @GiteaBot
Fixed race condition when deleting documents by repoId in ElasticSear…
908e1d4 
…ch (go-gitea#32185)

Resolves go-gitea#32184

---------

Signed-off-by: Bruno Sofiato <[email protected]>
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 3, 2024
@GiteaBot GiteaBot mentioned this pull request Oct 3, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Oct 3, 2024
lunny pushed a commit that referenced this pull request Oct 3, 2024
@GiteaBot @bsofiato
Fixed race condition when deleting documents by repoId in ElasticSear…
361221c 
…ch (#32185) (#32188)

Backport #32185 by @bsofiato

Resolves #32184

Signed-off-by: Bruno Sofiato <[email protected]>
Co-authored-by: Bruno Sofiato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@lunny lunny lunny approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Race condition when running ES delete_by_query
5 participants
@bsofiato @lunny @techknowlogick @denyskon @GiteaBot