Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade some dependencies include minio-go #32166

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Upgrade some dependencies include minio-go #32166

merged 2 commits into from
Oct 3, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 1, 2024

backport #32156

@GiteaBot GiteaBot added this to the 1.22.3 milestone Oct 1, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 1, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 1, 2024
@lunny lunny changed the title upgrade minio Upgrade some dependencies include minio-go Oct 1, 2024
sundaram2021
sundaram2021 reviewed Oct 1, 2024
View reviewed changes
Copy link

@sundaram2021 sundaram2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter checks should also be given priority in actions becuase in these whole module version is changed and these may or may not be linter safe.
.
.
.
.
if these linter tests are done somehow internally or anything like that
then its perfectly to merge it

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 3, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 3, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 3, 2024
@lunny lunny enabled auto-merge (squash) October 3, 2024 01:15
@lunny lunny merged commit 85897f9 into go-gitea:release/v1.22 Oct 3, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundaram2021 sundaram2021 sundaram2021 left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@yp05327 yp05327 yp05327 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.3
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @techknowlogick @yp05327 @sundaram2021 @GiteaBot @manvalls