Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure GetCSRF doesn't return an empty token (#32130) #32157

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Ensure GetCSRF doesn't return an empty token (#32130) #32157

merged 2 commits into from
Oct 1, 2024

Commits on Sep 30, 2024

  1. Ensure GetCSRF doesn't return an empty token (go-gitea#32130) 

    Since page templates keep changing, some pages that contained forms with
CSRF token no longer have them.

It leads to some calls of `GetCSRF` returning an empty string, which
fails the tests. Like

https://github.com/go-gitea/gitea/blob/3269b04d61ffe6a7ce462cd05ee150e4491124e8/tests/integration/attachment_test.go#L62-L63

The test did try to get the CSRF token and provided it, but it was
empty.
    @wolfogre @GiteaBot
    wolfogre authored and GiteaBot committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2cac3cc View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'release/v1.22' into backport-32130-v1.22

    @GiteaBot
    GiteaBot authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    8903d39 View commit details
    Browse the repository at this point in the history