Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add {{TEST_MINIO_ENDPOINT}} for local testing "with/without" docker + fix pgsql testing doc #32105

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

sommerf-lf
Copy link
Contributor

@sommerf-lf sommerf-lf commented Sep 21, 2024

while testing i found out that testing locally as documented in the changed README.md for pgsql isn't working because of the minio dependency. reworked this to by default be still docker, but allow for for local with only minio in docker and testing on bare metal.
also depending on this: fixed docs for running pgsql test

Closes: #32168 (by changing documentation for pgsql tests)
Closes: #32169 (by changing documentation, Makefile & pgsql.ini.tmpl: adding {{TEST_MINIO_ENDPOINT}})

sry for the combined pr, but when testing I ran into this issue and first thought they were related and now finally address the same problem: not beeing able to run pgsql integration tests as described in the according README.md

…th docker outside from docker, alter docu accordingly + fix pgsql testing docu
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 21, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2024
@sommerf-lf sommerf-lf marked this pull request as ready for review September 22, 2024 12:21
@sundaram2021
Copy link

have you raised an issue first when you found out something so that maintainers can have chat over it.

it will be helpful to raise an issue first (if not ) !

and how to reproduce it ?

Thaks

@sommerf-lf
Copy link
Contributor Author

have you raised an issue first when you found out something so that maintainers can have chat over it.

it will be helpful to raise an issue first (if not ) !

and how to reproduce it ?

Thaks

Hi, sry I haven't raised an issue (yet).
Will revise and link. :)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 2, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 3, 2024
@lunny lunny enabled auto-merge (squash) October 3, 2024 00:20
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 3, 2024
@lunny lunny merged commit 0b1b403 into go-gitea:main Oct 3, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Oct 3, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs modifies/internal size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/testing
Projects
None yet
5 participants