Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for searching users by email #30908

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Add support for searching users by email #30908

merged 5 commits into from
Oct 4, 2024

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented May 9, 2024

Fix #30898

we have an option SearchByEmail, so enable it, then we can search user by email.
Also added a test for it.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 9, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 9, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels May 9, 2024
@yp05327 yp05327 added the topic/api Concerns mainly the API label May 9, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 9, 2024
techknowlogick
techknowlogick requested changes May 9, 2024
View reviewed changes
Copy link
Member

@techknowlogick techknowlogick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily blocking as this may expose hidden emails. Perhaps this should be admin only?

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 9, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 9, 2024
@yp05327
Copy link
Contributor Author

yp05327 commented May 9, 2024

Updated

@yp05327
Copy link
Contributor Author

yp05327 commented Oct 3, 2024

@techknowlogick
Can you review this PR again?

@lunny lunny added this to the 1.23.0 milestone Oct 3, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Oct 4, 2024
@techknowlogick techknowlogick enabled auto-merge (squash) October 4, 2024 17:11
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 4, 2024
@techknowlogick techknowlogick merged commit 5d6d025 into go-gitea:main Oct 4, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@a1012112796 a1012112796 a1012112796 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. topic/api Concerns mainly the API
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Search users by Email Address
5 participants
@yp05327 @lunny @techknowlogick @a1012112796 @GiteaBot