-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for multiple LDAP servers in a auth source (go-gitea#6898) #12480
Conversation
Added support for multiple LDAP(S) servers in auth source. Servers are separated by space characters.
Suggestions:
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
We needs some tests for this PR. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
Please resolve the conflicts. |
It has been stale for a long time and I can't think of a way to handling it other than closing it. Feel free to reopen if there's any new progress and I could also help. |
Fixes Feature-Request #6898
Added support for multiple LDAP(S) servers in a auth source.
Servers are separated by space characters.
Before this pull request:
func dial
gets a string containing the LDAP server and try to connect.With this pull request:
func dial
gets a string containing the LDAP server or multiple LDAP servers separated by space character.It splits the string into a list of strings and try to connect to the first, but will try the second, if the first fails, etc.
Leading to the possibility to provide a backup LDAP servers if the main server is not reachable e.g. because of maintaince.
Best
~Rob