close failed connections (#6898)

Signed-off-by: abhishek818 <[email protected]>
go-gitea · Jul 22, 2024 · 5bdec11 · 5bdec11
1 parent 8574aa6
commit 5bdec11
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/services/auth/source/ldap/source_search.go b/services/auth/source/ldap/source_search.go
@@ -129,6 +129,7 @@ func dial(source *Source) (*ldap.Conn, error) {
 			conn, err := ldap.DialTLS("tcp", net.JoinHostPort(host, strconv.Itoa(source.Port)), tlsConfig)
 			if err != nil {
 				// Connection failed, try again with the next host.
+				conn.Close()
 				log.Trace("error during Dial for host %s: %w", host, err)
 				continue
 			}
@@ -139,6 +140,7 @@ func dial(source *Source) (*ldap.Conn, error) {
 
 		conn, err := ldap.Dial("tcp", net.JoinHostPort(host, strconv.Itoa(source.Port)))
 		if err != nil {
+			conn.Close()
 			log.Trace("error during Dial for host %s: %w", host, err)
 			continue
 		}