Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix walletconnect on non-mainnet chains #73

Merged
merged 1 commit into from
Aug 8, 2023
Merged

fix walletconnect on non-mainnet chains #73

merged 1 commit into from
Aug 8, 2023

Conversation

jfschwarz
Copy link
Collaborator

@jfschwarz jfschwarz commented Aug 8, 2023

This is a quick fix that will only make it work for existing connections.

Due to the quite questionable design choices made by WalletConnect V2 we'll need to set the network BEFORE requesting the wallet connection. So we can no longer just read the chain ID from the wallet after connecting. This means we'll probably have to let the user manually select a chain as a first step.

@jfschwarz jfschwarz merged commit cc7e9fd into main Aug 8, 2023
1 of 2 checks passed
@jfschwarz jfschwarz deleted the wc2-gc-fix branch August 8, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant