Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Migration to Zodiac Core and Task Enhancements in Zodiac Mod Starter Kit #8

Merged
merged 8 commits into from
Aug 30, 2024

Conversation

cristovaoth
Copy link
Contributor

@cristovaoth cristovaoth commented Jul 30, 2024

Description:

This Pull Request introduces the migration to the new @gnosis-guild/zodiac-core package and improves task management within the zodiac-mod-starter-kit repository. The key goal is to replace legacy dependencies to ensure better modularity and maintainability. This PR also includes updates to the project configuration, task scripts, and dependency versions.

Key Changes:

  1. Migration to Zodiac Core:

    • Replaced all previous imports from @gnosis.pm/zodiac with @gnosis-guild/zodiac-core.
    • Updated MyModule.sol and deployment scripts to use the new zodiac-core methods and utilities.
    • Removed legacy factory files (eip2470.ts, moduleProxyFactory.ts) that are now handled by zodiac-core.
  2. Task Enhancements:

    • Introduced deployFactories, deployMastercopy, and deployProxy tasks from zodiac-core to streamline deployment processes.
    • Updated deployment scripts (01_mastercopy_module.ts, 03_proxy_module.ts) to use the new task structure.
    • Created a new utility (eip1193.ts) for adapting providers, aligning with zodiac-core.
  3. Configuration Updates:

    • Updated hardhat.config.ts to use Sepolia network configuration.
    • Modified .env.example to reflect the network change to Sepolia.
    • Updated GitHub Actions CI configuration to use Node.js version 20.
  4. Dependency Upgrades:

    • Upgraded to the latest versions of several dependencies, including:
      • @gnosis-guild/zodiac-core
      • hardhat, eslint, typescript, and other related packages.
    • Removed deprecated dependencies and replaced them with their updated counterparts.
  5. Test Suite Updates:

    • Adjusted tests to be compatible with the new zodiac-core structure.
    • Refactored assertions in test files to reflect changes in contract logic.

Solution:

The migration to zodiac-core significantly improves the modularity and maintainability of the codebase. It also streamlines the deployment and testing processes by leveraging the new utilities provided by zodiac-core. The PR cleans up outdated dependencies and configurations, ensuring the project is up-to-date with the latest tools and practices.

@juliopavila juliopavila changed the title Use zodiac-core Feat: Migration to Zodiac Core and Task Enhancements in Zodiac Mod Starter Kit Aug 27, 2024
Copy link

Pull Request Test Coverage Report for Build 10584566234

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.333%

Totals Coverage Status
Change from base Build 9972107398: 0.0%
Covered Lines: 11
Relevant Lines: 11

💛 - Coveralls

@samepant samepant merged commit 5203fd6 into main Aug 30, 2024
1 check passed
@samepant samepant deleted the use-zodiac-core branch August 30, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants