Skip to content

Commit

Permalink
Fix parseInt, add tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Giacomo Licari committed Nov 2, 2023
1 parent 077d972 commit b822862
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 2 deletions.
7 changes: 5 additions & 2 deletions exporter/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,11 @@ func SanitizeHexIntValue(s string) (int64, error) {
var value int64
var resultErr string

// Check if value is an hex integer, e.g. 0x1d54c54 => 30755924
if value, err = strconv.ParseInt(s, 16, 64); err == nil {
// remove 0x suffix if found in the input string
cleaned := strings.Replace(s, "0x", "", -1)
cleaned = strings.Replace(cleaned, "\"", "", -1)

if value, err = strconv.ParseInt(cleaned, 16, 64); err == nil {
return value, nil
}
resultErr = fmt.Sprintf("%s", err)
Expand Down
21 changes: 21 additions & 0 deletions exporter/util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,27 @@ func TestSanitizeValue(t *testing.T) {
}
}

func TestSanitizeValueHex(t *testing.T) {
tests := []struct {
Input string
ExpectedOutput int64
ShouldSucceed bool
}{
{"0x1d55195", 30757269, true},
{"\"0x1d55195\"", 30757269, true},
}

for i, test := range tests {
actualOutput, err := SanitizeHexIntValue(test.Input)
if err != nil && test.ShouldSucceed {
t.Fatalf("Value snitization test %d failed with an unexpected error.\nINPUT:\n%q\nERR:\n%s", i, test.Input, err)
}
if test.ShouldSucceed && actualOutput != test.ExpectedOutput {
t.Fatalf("Value sanitization test %d fails unexpectedly.\nGOT:\n%d\nEXPECTED:\n%d", i, actualOutput, test.ExpectedOutput)
}
}
}

func TestSanitizeValueNaN(t *testing.T) {
actualOutput, err := SanitizeValue("<nil>")
if err != nil {
Expand Down

0 comments on commit b822862

Please sign in to comment.