This repository has been archived by the owner on Aug 24, 2021. It is now read-only.
add tokenFallback function for ERC223 compatibility #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would really need to see that implemented to support ERC223 tokens ! Triggering an event could be also a good option like in |
|
Just a little comment on that, there is already a fallback function in the contract (https://github.com/gnosis/MultiSigWallet/blob/master/contracts/MultiSigWallet.sol#L95) I just tried to send ERC223 to the regular gnosis contract and it works since it seems to fall into that method, so adding the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to make the Gnosis MultiSig ERC223 compatible the
tokenFallbackfunction with an empty body does the trick.This does not impact the functionality of the contract in any way and does not pose a security vulnerability.