Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MsgRun transaction execution #91

Conversation

jinoosss
Copy link
Member

@jinoosss jinoosss commented Feb 5, 2024

Description

This PR adds support for running transactions of type vm.m_run. (gnolang/gno#1001)

Additionally, since gno's MemPackage does not use json tags,
I added a mapping to the decode function so that we can read data from gno.

@jinoosss jinoosss force-pushed the feature/add-the-msgrun-transaction-execution-function branch from 8a84689 to 862978d Compare February 5, 2024 04:15
Copy link
Member

@zivkovicmilos zivkovicmilos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this addition, it's something we never got around to adding 🙏

I've left minor comments, otherwise it should be good to go 🚀

proto/gno/vm.proto Outdated Show resolved Hide resolved
src/wallet/utility/utility.ts Outdated Show resolved Hide resolved
src/wallet/wallet.ts Outdated Show resolved Hide resolved
@jinoosss
Copy link
Member Author

jinoosss commented Feb 9, 2024

@zivkovicmilos,
Thank you for your thorough review.
It helped me see some things I missed.

I modified the JS mapping.
I modified and utilized JSON handling functions for proto objects.

If you don't mind, please check it again.

@zivkovicmilos zivkovicmilos merged commit 51c5999 into gnolang:main Feb 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants