-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k_BT to HPMC integrator #1869
Draft
surajkannur
wants to merge
23
commits into
trunk-major
Choose a base branch
from
new_kbT_variant_hpmc
base: trunk-major
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
github-actions
bot
added
the
stale
There has been no activity on this for some time.
label
Sep 11, 2024
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
…hoomd-blue into new_kbT_variant_hpmc Pre-commit to fix code format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,$k_BT$ was assumed to be 1. In this PR, $k_BT$ is implemented as a variant in the HPMC integrator.
Motivation and context
Assuming$k_BT = 1$ meant that the well depth of the potential had to be rescaled to simulate different temperatures in the case of patchy particles. It also made interpreting the $\beta P$ output of the SDF compute difficult. With this change
the temperature can be user defined.
How has this been tested?
hoomd-validation: Simple-polygon
TODO other tests
TODO documentation
Change log
Checklist:
sphinx-doc/credits.rst
) in the pull request source branch.