Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the height of collapsed toots to 12 rem (192 px with default browser settings) #2702

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yurkobb
Copy link

@yurkobb yurkobb commented May 5, 2024

As noted in #2483, current collapsed toots barely display the first line of the text of the toot, which basically hides the toot almost entirely.

This PR increases the height of a collapsed toot to 12 rem (192 px if the user didn't change their browser's default font size), which is about the height of a "normal" 500-character toot on a 1920x1080 desktop with 100% zoom. This allows the reader to have an idea about the toot's contents to decide whether to unfold it or not.

It would be perhaps even better to have the height be set dynamically based on the maximum non-collapsed height configured in the app settings, but that is a task for a separate PR, as it would require more work.

This fixes the immediate readability problem with collapsed toots.

With increasing the collapsed toot height, the overlay gradient covered too much of the text making it unreadable. This adjusts it so that it covers only the lower half of the toot.
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant