Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: punycode error for non CI #2587

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

avallete
Copy link
Contributor

Description

Following #2581

This PR fixed an issue with CI but re-introduced the issue with the warning for node >= 21 because instead of conditionally importing the cross-fetch deps only if needed, it was importing it at the top of the file (so that was executed at file load whatever the context).

This PR reinstate the #2573 fix, but keep also keep the "CI fix" around.

Related Issue

Motivation and Context

Previous Behaviour / Output

New Behaviour / Output

How Has This Been Tested?

Screenshots (if appropriate):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant