Fixing short discord names

[kkatusic]

Fix #1132

@kristoferlund check if everything ok. I checked only on two places is required for username length, user schema and user_account schema.

There isn't any test required by name length, on front and bot side.

Only that is somehow suspicion to me is this bot code, cc @Vyvy-vi

https://github.com/givepraise/praise/blob/main/packages/discord-bot/src/utils/dmTargets.ts#L105

I don't know why we have here 24 fixed number.

[kristoferlund]

Yes, that looks a bit suspicious :)

Let's unify username and useraccount.names lengths to 2-32 characters.

@kkatusic You need to look at users.service as well:

generateUserNameFromAccount
generateValidUsername

[kkatusic]

@kristoferlund I checked that inside users username schema and set minimum of 2 character as well.

And confirm this that you want on our side set up to 32 max character? Asking this because we have some regex for that:

praise/packages/api/src/users/utils/is-valid-username.ts

Line 12 in 982fe9d

const pattern = /^[a-z0-9][a-z0-9_.-]{2,48}[a-z0-9]$/;

:)

[kristoferlund]

@kkatusic Oh yes, forgot. We use eth address as username in some cases, when user logs in to dashboard without first activating their account. So let's not change username maxlength.

[kkatusic]

@kristoferlund than this is done?

[Vyvy-vi]

Would we also need to account for the twitter length limit? (2-15)

[kristoferlund]

All looks good, tests passing. I added 2-32 requirements to dashboard as well.