Only sync the job's images #1425
Merged
+43
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filiptronicek
commented
Sep 12, 2024
Comment on lines
-94
to
-97
| # limit what we promote to latest for the current year only | ||
| current_year=$(date +%Y) | ||
| current_month="" | ||
| sed -i "s/CURRENT_YEAR/$current_year/g; s/CURRENT_MONTH/$current_month/g" "${GITHUB_WORKSPACE}/.github/promote-images.yml" |
There was a problem hiding this comment.
This here wasn't needed, as we only used the keys and not their values in the $IMAGES below
kylos101
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes things around to not sync anything else from GAR to Dockerhub besides the images that were built in the current job.
Related Issue(s)
Contributes to ENT-749
Addresses https://gitpod.slack.com/archives/C01RC164G48/p1726069432742589?thread_ts=1725887846.208599&cid=C01RC164G48