Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Branch Scanning #258

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

JennieOhyoung
Copy link

I made some changes to this script because:

  1. The commit check is only looking at the default branch and not checking other branches. I added the '-b' option to enable branch scanning.
  2. Some customers are unsure how to get started, so I added a doc link on how to generate a token and specified the date format.

@JennieOhyoung
Copy link
Author

Note: please allow me to do the merging after review. I have a customer currently using the script off of this branch.

@primetheus
Copy link
Contributor

@JennieOhyoung this is really great! Can you update it to use spaces instead of tabs? The formatting of the additions makes some of the additions a bit hard to follow 🙏 🙇

Copy link
Contributor

@primetheus primetheus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the suggested changes feature only allows one line at a time, but lines 119-145, as well as 266-269 have formatting issues as well. Might be a bit of a nit-pick, but helps with the readability when it's all formatted the same 🙇

api/ruby/find-inactive-members/find_inactive_members.rb Outdated Show resolved Hide resolved
@github github deleted a comment from Aa88s Aug 12, 2019
end
# Get all the branches so we can loop through them
if @branches
@client.branches(repo).each do |branch|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JennieOhyoung: looks as if indenting is broken here

primetheus
primetheus previously approved these changes Mar 20, 2020
api/ruby/find-inactive-members/find_inactive_members.rb Outdated Show resolved Hide resolved
@primetheus primetheus dismissed their stale review March 20, 2020 14:18

misread notification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants