Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc cleanups on git command invocation #2521

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Misc cleanups on git command invocation #2521

merged 2 commits into from
Oct 3, 2024

Commits on Oct 3, 2024

  1. Extract runGitCommand()

    @cklin
    cklin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    955d001 View commit details
    Browse the repository at this point in the history

  2. Rename determineMergeBaseCommitOid() 

    The name suggests that the function computes the merge base, which for
Git means specifically the best common ancestors between multiple
commits or branches (see `git merge-base`).

But what the function actually does is to calculate the HEAD commit of
the PR base branch, as derived from the PR merge commit that the action
analyzes. So even though the function has to do with "merge" and "base",
using the term "merge base" is still misleading at best.

This commit renames the function to determineBaseBranchHeadCommitOid(),
which more clearly indicates what the function does.
    @cklin
    cklin committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d64cca4 View commit details
    Browse the repository at this point in the history