Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid uploading eslint sarif for dependabot PR #2499

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Sep 23, 2024

Dependabot does not have security-events: write permission.

See #2485

@aeisenberg aeisenberg marked this pull request as ready for review September 23, 2024 19:11
@aeisenberg aeisenberg requested a review from a team as a code owner September 23, 2024 19:11
Dependabot does not have `security-events: write` permission.s
angelapwen
angelapwen previously approved these changes Sep 23, 2024
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@aeisenberg
Copy link
Contributor Author

Minor change to align with what we're doing for vscode-codeql. Can you re-review?

Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@aeisenberg aeisenberg merged commit 2cddcb1 into main Sep 23, 2024
262 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/no-upload-sarif branch September 23, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants