Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SARIF validation] turn URI errors into warnings #2487

Merged
merged 3 commits into from
Sep 17, 2024
Merged

[SARIF validation] turn URI errors into warnings #2487

merged 3 commits into from
Sep 17, 2024

Conversation

rvermeulen
Copy link
Contributor

@rvermeulen rvermeulen commented Sep 16, 2024 •
edited
Loading

This PR extends the list of string format's for which we turn validation errors into warnings to ensure we don't fail on invalid URIs.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@rvermeulen rvermeulen changed the title Rvermeulen/uri errors as warnings [SARIF validation] turn uri errors as warnings Sep 16, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 16, 2024
View reviewed changes
src/upload-lib.ts Fixed Show fixed Hide fixed
src/upload-lib.ts Fixed Show fixed Hide fixed
@rvermeulen rvermeulen changed the title [SARIF validation] turn uri errors as warnings [SARIF validation] turn URI errors into warnings Sep 17, 2024
@rvermeulen rvermeulen force-pushed the rvermeulen/uri-errors-as-warnings branch from 062e68a to b8336bf Compare September 17, 2024 03:04
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 17, 2024
View reviewed changes
src/upload-lib.ts Fixed Show fixed Hide fixed
src/upload-lib.ts Fixed Show fixed Hide fixed
src/upload-lib.ts Fixed Show fixed Hide fixed
@rvermeulen rvermeulen force-pushed the rvermeulen/uri-errors-as-warnings branch from b8336bf to 952f9e8 Compare September 17, 2024 03:14
@rvermeulen rvermeulen force-pushed the rvermeulen/uri-errors-as-warnings branch from 952f9e8 to 642bbfc Compare September 17, 2024 03:22
@rvermeulen rvermeulen marked this pull request as ready for review September 17, 2024 03:22
@rvermeulen rvermeulen requested a review from a team as a code owner September 17, 2024 03:22
aeisenberg
aeisenberg previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits. Non-blocking.

src/upload-lib.ts Show resolved Hide resolved
src/upload-lib.ts Show resolved Hide resolved
@aeisenberg aeisenberg added the Update dependencies Trigger PR workflow to update dependencies label Sep 17, 2024
aeisenberg
aeisenberg previously approved these changes Sep 17, 2024
View reviewed changes
@aeisenberg aeisenberg added Rebuild Re-transpile JS & re-generate workflows and removed Update dependencies Trigger PR workflow to update dependencies labels Sep 17, 2024
@aeisenberg
Copy link
Contributor

Rebuilding the JS.

@aeisenberg
Copy link
Contributor

The rebuild action is failing since it's in a fork. @rvermeulen, if you add the Rebuild label, the js will be rebuilt, so you don't need to do it locally.

@rvermeulen
Copy link
Contributor Author

Mmm, I rebuild it locally. Let me look at the failures.

@rvermeulen
Copy link
Contributor Author

The merge from main caused the JavaScript files to go stale, pushed a rebuild.

@rvermeulen rvermeulen merged commit cb28816 into github:main Sep 17, 2024
306 checks passed
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
Rebuild Re-transpile JS & re-generate workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvermeulen @aeisenberg