Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only warn about path filters in the Action if the CLI doesn't already warn #2161

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Feb 22, 2024

We are moving the notice when a language does not support path filtering into the CLI so that it's available for all customers including those using third-party CI systems. Therefore, to avoid duplicate warnings, this PR updates the Action such that it only warns for older CLIs that don't support this feature.

This does mean that customers on older versions of the Action using newer CLIs might see the warning twice in the logs. I don't think this is enough of a problem to be worth addressing.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner February 22, 2024 21:35
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, and agree that the double-warning for folks on older versions isn't too big of a deal 😄

@henrymercer henrymercer merged commit 17c5ab2 into main Feb 27, 2024
297 checks passed
@henrymercer henrymercer deleted the henrymercer/path-filter-warning-cli branch February 27, 2024 09:59
@github-actions github-actions bot mentioned this pull request Feb 29, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants