Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable C++ deptrace when using autobuild build mode #2160

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Feb 22, 2024

This PR fixes a bug with the experimental internal-only build mode functionality where we wouldn't enable deptrace when extracting C++ using database trace-command. Risk is low since this functionality is guarded behind the internal-only build-mode input.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner February 22, 2024 18:19
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. This looks fine.

src/analyze.ts Show resolved Hide resolved
@henrymercer henrymercer merged commit a74dcdb into main Feb 22, 2024
297 checks passed
@henrymercer henrymercer deleted the henrymercer/deptrace-with-build-mode branch February 22, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants