Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Test: Only delete SARIF in PR check if not running on a fork #2085

Closed
wants to merge 5 commits into from

Conversation

angelapwen
Copy link
Contributor

@angelapwen angelapwen commented Jan 13, 2024

Just testing that the non-fork behavior is preserved 😄

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

The `Submit SARIF after failure` PR Check was failing when opened on a fork because of a permissions problem when deleting the uploaded SARIF. This change should fix this by only deleting the SARIF when the owner of the current repository is `github`.
@angelapwen angelapwen added the DO NOT MERGE This pull request should not be merged yet label Jan 13, 2024
@angelapwen
Copy link
Contributor Author

Closing as #2084 has been merged

@angelapwen angelapwen closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE This pull request should not be merged yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant