Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for new analysis summary and scaling reserved RAM feature flag usage #1788

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Fixes for new analysis summary and scaling reserved RAM feature flag usage #1788

merged 3 commits into from
Jul 18, 2023

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Jul 18, 2023 •
edited
Loading

  • Add the _enabled suffix to the scaling reserved RAM feature flag
  • Add a unit test that all feature flags end in _enabled (since this is a convention we use on the API side)
  • Add unit tests for the new analysis summary flags

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner July 18, 2023 12:46
angelapwen
angelapwen approved these changes Jul 18, 2023
View reviewed changes
src/codeql.ts Show resolved Hide resolved
src/feature-flags.test.ts Show resolved Hide resolved
@henrymercer henrymercer merged commit 651d091 into main Jul 18, 2023
342 checks passed
@henrymercer henrymercer deleted the henrymercer/fix-feature-flag-usage branch July 18, 2023 13:14
This was referenced Jul 18, 2023
Closed
Merged
@aliscco aliscco mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelapwen angelapwen angelapwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @angelapwen