Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the no code found URL #1779

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Correct the no code found URL #1779

merged 4 commits into from
Jul 20, 2023

Conversation

peternewman
Copy link
Contributor

@peternewman peternewman commented Jul 17, 2023

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@peternewman peternewman requested a review from a team as a code owner July 17, 2023 11:55
@peternewman
Copy link
Contributor Author

@angelapwen
Copy link
Contributor

Thank you for your contribution @peternewman! The repository uses TypeScript transpiled into Javascript: could you update the TypeScript file at src/error-matcher.ts and then running npm run build to auto-generate the transpiled JS file and mapping?

We'll look into updating the link in the official documentation as well — thanks again 💖

@angelapwen
Copy link
Contributor

angelapwen commented Jul 17, 2023

Hello! I've just been reminded that we are using a new shortlink — https://gh.io/troubleshooting-code-scanning/no-source-code-seen-during-build (the one referenced in the documentation) — which will allow us to avoid this problem in the future, as the link will handle the case where the docs URL changes in the future. Do you mind updating to this link as well? Thanks!

@angelapwen
Copy link
Contributor

Everything looks good, you'll just need to run the build command again to regenerate the transpiled files to pass the failing PR check!

npm run build run on the root directory should give you some file changes ✨

@peternewman
Copy link
Contributor Author

Do you want a changelog entry for this?

* [ ]  Confirm the [changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) has been updated if necessary.

Thank you for your contribution @peternewman! The repository uses TypeScript transpiled into Javascript

Oops, I think I'd found that first during the code search, then edited the wrong file!

We'll look into updating the link in the official documentation as well — thanks again 💖

Excellent thanks.

Hello! I've just been reminded that we are using a new shortlink — https://gh.io/troubleshooting-code-scanning/no-source-code-seen-during-build (the one referenced in the documentation) — which will allow us to avoid this problem in the future, as the link will handle the case where the docs URL changes in the future. Do you mind updating to this link as well? Thanks!

Even better!

Everything looks good, you'll just need to run the build command again to regenerate the transpiled files to pass the failing PR check!

Yeah I was just waiting until I was in front of a proper machine not just doing it in a web browser!

Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't need a changelog entry here as we generally don't add one if we're just updating documentation — thank you for checking though!

I've approved the checks to run again 😸

@angelapwen
Copy link
Contributor

The failing checks are unrelated to your PR. We'll work on resolving them, please hold tight 😄

@peternewman
Copy link
Contributor Author

It looks like it's all green now @angelapwen

Perhaps you should have enabled automerge! 😄

@angelapwen
Copy link
Contributor

Ha, I was thinking that perhaps you'd want the pleasure of clicking the merge button 😆 I'll merge now! Thank you again 💖

@angelapwen angelapwen merged commit ce84bed into github:main Jul 20, 2023
342 checks passed
@peternewman peternewman deleted the patch-1 branch July 20, 2023 10:07
@peternewman
Copy link
Contributor Author

Ha, I was thinking that perhaps you'd want the pleasure of clicking the merge button laughing I'll merge now! Thank you again sparkling_heart

I don't think I remember seeing it, and I don't think I'd expect to unless you've given me more rights to the repo than a normal user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants